Messages in this thread | | | Subject | Re: [RFC V2 0/6] media: Hantro: Split iMX8MQ VPU into G1 and G2 with blk-ctrl support | From | Benjamin Gaignard <> | Date | Wed, 8 Dec 2021 10:32:55 +0100 |
| |
Le 07/12/2021 à 02:54, Adam Ford a écrit :
> Currently, the VPU in the i.MQ8MQ is appearing as one codec, but in > reality, it's two IP blocks called G1 and G2. There is initialization > code in VPU code to pull some clocks, resets and other features which > has been integrated into the vpu-blk-ctrl for the i.MX8M Mini and a > similar method can be used to make the VPU codec's operate as > stand-alone cores without having to know the details of each other > or the quirks unique to the i.MX8MQ, so the remaining code can be > left more generic. > > This series was started by Lucas Stach with one by Benjamin Gaignard. > Most patches have been modified slightly by me. It's in an RFC state > because I wasn't sure how to best handle the signatures and wasn't sure > if I could base it off the branch I did. > > Since the g-streamer and media trees are in a constant state of > change, this series is based on > > git://linuxtv.org/hverkuil/media_tree.git for-v5.17e > > The downstream code from NXP shows the G1 and G2 clocks running > at 600MHz, but between the TRM and the datasheet, there is some > discrepancy. Because the NXP reference code used 600MHz, that is > what was chosen here. Users who need to adjust their G1 and G2 > clocks can do so in their board files.
Hi Adam,
Thanks for your patches, I have been able to reproduce VP9 results on my side (Fluster 147/303). In past I have notice spurious errors when using 600MHz clock on HEVC decode but not with 300MHz.
Regards, Benjamin
> > Fluster Results: > > ./fluster.py run -dGStreamer-H.264-V4L2SL-Gst1.0 > Ran 90/135 tests successfully in 61.966 secs > > ./fluster.py run -d GStreamer-VP8-V4L2SL-Gst1.0 > Ran 55/61 tests successfully in 7.660 secs > > > ./fluster.py run -d GStreamer-VP9-V4L2SL-Gst1.0 > Ran 144/303 tests successfully in 162.665 secs > > Changes log: > > V2: Make vpu-blk-ctrl enable G2 clock when enabling fuses. > Remove syscon from device tree and binding example > Added modified nxp,imx8mq-vpu.yaml from Benjamin Gaignard > > Adam Ford (2): > media: hantro: split i.MX8MQ G1 and G2 code > arm64: dts: imx8mq: Split i.MX8MQ G1 and G2 with vpu-blk-ctrl > > Benjamin Gaignard (1): > dt-bindings: media: nxp,imx8mq-vpu: Update the bindings for G2 support > > Lucas Stach (3): > dt-bindings: power: imx8mq: add defines for VPU blk-ctrl domains > dt-bindings: soc: add binding for i.MX8MQ VPU blk-ctrl > soc: imx: imx8m-blk-ctrl: add i.MX8MQ VPU blk-ctrl > > .../bindings/media/nxp,imx8mq-vpu.yaml | 58 +++++---- > .../soc/imx/fsl,imx8mq-vpu-blk-ctrl.yaml | 71 +++++++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 69 ++++++---- > drivers/soc/imx/imx8m-blk-ctrl.c | 68 +++++++++- > drivers/staging/media/hantro/hantro_drv.c | 4 +- > drivers/staging/media/hantro/hantro_hw.h | 2 +- > drivers/staging/media/hantro/imx8m_vpu_hw.c | 119 +++--------------- > include/dt-bindings/power/imx8mq-power.h | 3 + > 8 files changed, 237 insertions(+), 157 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mq-vpu-blk-ctrl.yaml > > > base-commit: d1888b0bfd2ddef2e8a81505ffa200b92cc32e0c
| |