lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] driver: pmc_atom: free pmc->regmap when pmc_setup_clks fails
On Mon, Dec 06, 2021 at 04:00:13PM +0200, Andy Shevchenko wrote:
> On Sun, Dec 05, 2021 at 04:44:19PM +0800, Dongliang Mu wrote:
> > Smatch reports:
> >
> > drivers/platform/x86/pmc_atom.c:496
> > pmc_setup_dev() warn: 'pmc->regmap' not released on lines: 496.
> >
> > Fix this by deallocating pm->regmap when pmc_setup_clks fails.
> >
> > Fixes: 282a4e4ce5f9("platform/x86: Enable Atom PMC platform clocks")
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
>
> It says v2 in the subject, what is in v2 exactly in comparison to v1?
>
> ...
>
> > ret = pmc_setup_clks(pdev, pmc->regmap, data);
> > - if (ret)
> > + if (ret) {
> > + iounmap(pmc->regmap);
> > dev_warn(&pdev->dev, "platform clocks register failed: %d\n",
> > ret);
>
> In this case it makes sense to move to
>
> dev_err(&pdev->dev, "platform clocks register failed: %d\n", ret);
>
> > + }

Also, what about cleaning up debugfs?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-12-06 15:08    [W:0.064 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site