Messages in this thread | | | Date | Mon, 6 Dec 2021 15:03:58 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v1 1/7] pid: Introduce helper task_is_in_root_ns() |
| |
Hi Leon,
On Mon, Dec 06, 2021 at 08:49:01AM +0200, Leon Romanovsky wrote: > On Sun, Dec 05, 2021 at 10:50:59PM +0800, Leo Yan wrote:
[...]
> > +static inline bool task_is_in_root_ns(struct task_struct *tsk) > > It is bad that this name doesn't reflect PID nature of this namespace. > Won't it better to name it task_is_in_init_pid_ns()?
Yes, task_is_in_init_pid_ns() is more clear.
Will respin for this. Thank you for suggestion!
Leo
| |