lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] erofs: Replace zero-length array with flexible-array member
    Date
    There is a regular need in the kernel to provide a way to declare
    having a dynamically sized set of trailing elements in a structure.

    Kernel code should always use `flexible array members' [1] for these
    cases. The older style of one-element or zero-length arrays should
    no longer be used [2].

    [1] https://en.wikipedia.org/wiki/Flexible_array_member
    [2] https://www.kernel.org/doc/html/v5.15/process/deprecated.html#zero-length-and-one-element-arrays

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
    ---
    fs/erofs/erofs_fs.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h
    index f4506a642a12..dda79afb901d 100644
    --- a/fs/erofs/erofs_fs.h
    +++ b/fs/erofs/erofs_fs.h
    @@ -209,7 +209,7 @@ struct erofs_xattr_ibody_header {
    __le32 h_reserved;
    __u8 h_shared_count;
    __u8 h_reserved2[7];
    - __le32 h_shared_xattrs[0]; /* shared xattr id array */
    + __le32 h_shared_xattrs[]; /* shared xattr id array */
    };

    /* Name indexes */
    @@ -226,7 +226,7 @@ struct erofs_xattr_entry {
    __u8 e_name_index; /* attribute name index */
    __le16 e_value_size; /* size of attribute value */
    /* followed by e_name and e_value */
    - char e_name[0]; /* attribute name */
    + char e_name[]; /* attribute name */
    };

    static inline unsigned int erofs_xattr_ibody_size(__le16 i_xattr_icount)
    --
    2.24.4
    \
     
     \ /
      Last update: 2021-12-06 13:18    [W:3.153 / U:1.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site