lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 154/207] drm/msm/devfreq: Fix OPP refcnt leak
    Date
    From: Rob Clark <robdclark@chromium.org>

    [ Upstream commit 59ba1b2b4825342676300f66d785764be3fcb093 ]

    Reported-by: Douglas Anderson <dianders@chromium.org>
    Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Reviewed-by: Douglas Anderson <dianders@chromium.org>
    Tested-By: Steev Klimaszewski <steev@kali.org>
    Reviewed-by: Akhil P Oommen <akhilpo@codeaurora.org>
    Link: https://lore.kernel.org/r/20211105202021.181092-1-robdclark@gmail.com
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
    index 20006d060b5b5..4ac2a4eb984d8 100644
    --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
    +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
    @@ -20,6 +20,10 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
    struct msm_gpu *gpu = dev_to_gpu(dev);
    struct dev_pm_opp *opp;

    + /*
    + * Note that devfreq_recommended_opp() can modify the freq
    + * to something that actually is in the opp table:
    + */
    opp = devfreq_recommended_opp(dev, freq, flags);

    /*
    @@ -28,6 +32,7 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
    */
    if (gpu->devfreq.idle_freq) {
    gpu->devfreq.idle_freq = *freq;
    + dev_pm_opp_put(opp);
    return 0;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-12-06 17:11    [W:3.063 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site