lkml.org 
[lkml]   [2021]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 205/207] serial: liteuart: fix use-after-free and memleak on unbind
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 05f929b395dec8957b636ff14e66b277ed022ed9 upstream.

    Deregister the port when unbinding the driver to prevent it from being
    used after releasing the driver data and leaking memory allocated by
    serial core.

    Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
    Cc: stable@vger.kernel.org # 5.11
    Cc: Filip Kokosinski <fkokosinski@antmicro.com>
    Cc: Mateusz Holenko <mholenko@antmicro.com>
    Reviewed-by: Stafford Horne <shorne@gmail.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/r/20211117100512.5058-2-johan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/tty/serial/liteuart.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/tty/serial/liteuart.c
    +++ b/drivers/tty/serial/liteuart.c
    @@ -295,6 +295,7 @@ static int liteuart_remove(struct platfo
    struct uart_port *port = platform_get_drvdata(pdev);
    struct liteuart_port *uart = to_liteuart_port(port);

    + uart_remove_one_port(&liteuart_driver, port);
    xa_erase(&liteuart_array, uart->id);

    return 0;

    \
     
     \ /
      Last update: 2021-12-06 17:10    [W:4.716 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site