Messages in this thread | | | Date | Mon, 6 Dec 2021 11:23:33 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 04/15] arm64: dts: qcom: sm8450-qrd: Add reserved gpio range for QRD |
| |
On 01-12-21, 16:07, Konrad Dybcio wrote: > > On 01.12.2021 08:29, Vinod Koul wrote: > > Some tlmm gpios are reserved, so mark them as such in QRD DTS > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > index 127d32502555..8dcd41c4e5ab 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > @@ -24,6 +24,10 @@ &qupv3_id_0 { > > status = "okay"; > > }; > > > > +&tlmm { > > + gpio-reserved-ranges = <28 4>, <36 4>; > > +}; > > + > > &uart7 { > > status = "okay"; > > }; > > > Personally I'd squash this into the patch that introduced the DT and
I feel it is the right things to do, a patch should not touch a different file. soc dts and board dts and two different entities and should be patched separately!
> move it to the end of the series, but I reckon it's fine either way.. > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Thanks for the detailed review.
-- ~Vinod
| |