lkml.org 
[lkml]   [2021]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH -mm 5/5] bpf/progs: replace hard-coded 16 with TASK_COMM_LEN
    On Sat, Dec 4, 2021 at 1:53 AM Yafang Shao <laoar.shao@gmail.com> wrote:
    >
    > static int process_sample(void *ctx, void *data, size_t len)
    > {
    > - struct sample *s = data;
    > + struct sample_ringbuf *s = data;

    This is becoming pointless churn.
    Nack.

    > index 145028b52ad8..7b1bb73c3501 100644
    > --- a/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c
    > +++ b/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c
    > @@ -1,8 +1,7 @@
    > // SPDX-License-Identifier: GPL-2.0
    > // Copyright (c) 2019 Facebook
    >
    > -#include <linux/bpf.h>
    > -#include <stdint.h>
    > +#include <vmlinux.h>
    > #include <stdbool.h>
    > #include <bpf/bpf_helpers.h>
    > #include <bpf/bpf_core_read.h>
    > @@ -23,11 +22,11 @@ struct core_reloc_kernel_output {
    > int comm_len;
    > };
    >
    > -struct task_struct {
    > +struct task_struct_reloc {

    Churn that is not even compile tested.

    \
     
     \ /
      Last update: 2021-12-04 17:46    [W:6.925 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site