Messages in this thread | | | Date | Fri, 31 Dec 2021 18:27:12 +0800 | Subject | Re: [PATCH V3 1/6] tty: serial: meson: Drop the legacy compatible strings and clock code | From | Yu Tu <> |
| |
Hi Martin, Thank you very much for your reply.
On 2021/12/31 6:22, Martin Blumenstingl wrote: > [ EXTERNAL EMAIL ] > > On Thu, Dec 30, 2021 at 11:21 AM Yu Tu <yu.tu@amlogic.com> wrote: >> >> All mainline .dts files have been using the stable UART since Linux >> 4.16. Drop the legacy compatible strings and related clock code. >> >> Signed-off-by: Yu Tu <yu.tu@amlogic.com> > I have just realized that this cannot be dropped until my series "ARM: > dts: meson: fix UART device-tree schema validation" [0] is merged > > [...] >> -/* Legacy bindings, should be removed when no more used */ >> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-uart", >> - meson_serial_early_console_setup); > This part is still needed as long as above series is not merged yet. > If we remove this then earlycon will stop working on the 32-bit SoCs > unless [0] is merged. > > All other code below - except the of_device_id entry - can still be > removed since meson8.dtsi and meson8b.dtsi are using the non-legacy > clocks already. > > Sorry for only noticing this now. > I will add it back in the next patch and delete it after your submission is merged. > > Best regards, > Martin > > > [0] https://patchwork.kernel.org/project/linux-amlogic/cover/20211227180026.4068352-1-martin.blumenstingl@googlemail.com/ >
| |