Messages in this thread | | | Date | Thu, 30 Dec 2021 21:04:18 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] input: appletouch: initialize work before device registration |
| |
On Thu, Dec 30, 2021 at 05:11:51PM +0300, Pavel Skripkin wrote: > Syzbot has reported warning in __flush_work(). This warning is caused by > work->func == NULL, which means missing work initialization. > > This may happen, since input_dev->close() calls cancel_work_sync(&dev->work), > but dev->work initalization happens _after_ input_register_device() > call. > > So this patch moves dev->work initialization before registering input > device > > Fixes: 5a6eb676d3bc ("Input: appletouch - improve powersaving for Geyser3 devices") > Reported-and-tested-by: syzbot+b88c5eae27386b252bbd@syzkaller.appspotmail.com > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Applied, thank you.
-- Dmitry
| |