lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v3 45/48] perf c2c: Use more intention revealing iterator
    From
    Use perf_cpu_map__for_each_cpu in setup_nodes.

    Signed-off-by: Ian Rogers <irogers@google.com>
    ---
    tools/perf/builtin-c2c.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
    index b5c67ef73862..ad1fbeafc93d 100644
    --- a/tools/perf/builtin-c2c.c
    +++ b/tools/perf/builtin-c2c.c
    @@ -2015,7 +2015,7 @@ static int setup_nodes(struct perf_session *session)
    {
    struct numa_node *n;
    unsigned long **nodes;
    - int node, cpu;
    + int node, cpu, idx;
    int *cpu2node;

    if (c2c.node_info > 2)
    @@ -2057,13 +2057,13 @@ static int setup_nodes(struct perf_session *session)
    if (perf_cpu_map__empty(map))
    continue;

    - for (cpu = 0; cpu < map->nr; cpu++) {
    - set_bit(map->map[cpu], set);
    + perf_cpu_map__for_each_cpu(cpu, idx, map) {
    + set_bit(cpu, set);

    - if (WARN_ONCE(cpu2node[map->map[cpu]] != -1, "node/cpu topology bug"))
    + if (WARN_ONCE(cpu2node[cpu] != -1, "node/cpu topology bug"))
    return -EINVAL;

    - cpu2node[map->map[cpu]] = node;
    + cpu2node[cpu] = node;
    }
    }

    --
    2.34.1.448.ga2b2bfdf31-goog
    \
     
     \ /
      Last update: 2021-12-30 08:24    [W:8.718 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site