lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: pi433: add docs to packet_format and tx_start_condition enum
On Thu, Dec 30, 2021 at 11:57:48AM +0100, Greg KH wrote:
> > +/*
> > + * Defines the packet format used.
>
> What "Defines"? This is an odd sentence.

Noted. I will change that.

> > + * In both modes the length of the payload is limited to 255 bytes if AES
> > + * is not enabled or 64 bytes otherwise.
>
> What does this have to do with the format type?
>

The rationale was that I wanted the developer to know straight away how
much info would be possible to transfer given the combination of
encryption + packet_format settings.

But now that you mentioned it, I can see that this info/obs could be
misplaced. I will remove it.

> > + /* at least one byte in the FIFO */
> > fifo_not_empty
> > };
>
> Also, always run your patches through scripts/checkpatch.pl before
> sending them out. I couldn't take this patch for that reason alone :(
>

My apologies, I will be extra careful next time.

thanks,

Paulo A.

\
 
 \ /
  Last update: 2021-12-30 16:54    [W:0.028 / U:8.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site