Messages in this thread | | | Date | Thu, 30 Dec 2021 14:41:55 +0800 | Subject | Re: [PATCH] lib/mpi: add the return value check of kcalloc | From | Tianjia Zhang <> |
| |
Hi Zizhuang,
On 12/30/21 10:51 AM, Zizhuang Deng wrote: > Add the return value check of kcalloc to avoid potential > NULL ptr dereference. > > Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com> > --- > lib/mpi/mpi-mod.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c > index 47bc59edd4ff..6fd6900f0798 100644 > --- a/lib/mpi/mpi-mod.c > +++ b/lib/mpi/mpi-mod.c > @@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy) > mpi_normalize(m); > ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL); >
Remove this empty line.
> + if (!ctx) { > + return NULL; > + } > + > if (copy) { > ctx->m = mpi_copy(m); > ctx->m_copied = 1;
Thanks for pointing it out. Please send a copy to linux-crypto and Herbert Xu.
Best regards, Tianjia
| |