lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH linux] usb-storage: Remove redundant assignments
On Thu, Dec 30, 2021 at 06:38:19AM +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
>
> The assignments in these two places will be overwritten, so they
> should be deleted.
>
> The clang_analyzer complains as follows:
>
> drivers/usb/storage/sierra_ms.c:
>
> Value stored to 'retries' is never read
> Value stored to 'result' is never read
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> drivers/usb/storage/sierra_ms.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
> index b9f78ef..0774ba2 100644
> --- a/drivers/usb/storage/sierra_ms.c
> +++ b/drivers/usb/storage/sierra_ms.c
> @@ -130,8 +130,6 @@ int sierra_ms_init(struct us_data *us)
> struct swoc_info *swocInfo;
> struct usb_device *udev;
>
> - retries = 3;
> - result = 0;
> udev = us->pusb_dev;
>
> /* Force Modem mode */
> --
> 2.15.2
>
>

\
 
 \ /
  Last update: 2021-12-30 15:50    [W:0.029 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site