Messages in this thread | | | Date | Thu, 30 Dec 2021 13:12:26 +0100 | From | Florian Westphal <> | Subject | Re: [PATCH linux] netfilter: Remove unnecessary ret assignment |
| |
cgel.zte@gmail.com <cgel.zte@gmail.com> wrote: > From: luo penghao <luo.penghao@zte.com.cn> > > Regardless of whether the subsequent (copy_to_user(user, &info, *len) != 0) > holds, the value of ret will be assigned a new value. > > The clang_analyzer complains as follows: > > net/ipv6/netfilter/ip6_tables.c: > > Value stored to 'ret' is never read
Please fix this properly:
1. consider adding error unwinding instead. 2. net/ipv4/netfilter/ip_tables.c has same construct
| |