lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3] drm/mediatek: Fix unused-but-set variable warning
    Date
    clang reports a unused-but-set variable warning:
    drivers/gpu/drm/mediatek/mtk_cec.c:85:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable]

    In current implementation, mtk_cec_mask() writes val into target register
    and ignores the mask. After talking to our hdmi experts, mtk_cec_mask()
    should read a register, clean only mask bits, and update (val | mask) bits
    to the register.

    Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")

    Cc: Zhiqiang Lin <zhiqiang.lin@mediatek.com>
    Cc: CK Hu <ck.hu@mediatek.com>
    Cc: Matthias Brugger <matthias.bgg@gmail.com>

    Signed-off-by: Miles Chen <miles.chen@mediatek.com>

    ---

    Change since v1:
    add Fixes tag

    Change since v2:
    add explanation of mtk_cec_mask()

    Change-Id: Iec6402b0532942f4d0e8bc56817eb87b95c03fad
    ---
    drivers/gpu/drm/mediatek/mtk_cec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c
    index e9cef5c0c8f7..cdfa648910b2 100644
    --- a/drivers/gpu/drm/mediatek/mtk_cec.c
    +++ b/drivers/gpu/drm/mediatek/mtk_cec.c
    @@ -85,7 +85,7 @@ static void mtk_cec_mask(struct mtk_cec *cec, unsigned int offset,
    u32 tmp = readl(cec->regs + offset) & ~mask;

    tmp |= val & mask;
    - writel(val, cec->regs + offset);
    + writel(tmp, cec->regs + offset);
    }

    void mtk_cec_set_hpd_event(struct device *dev,
    --
    2.18.0
    \
     
     \ /
      Last update: 2021-12-30 10:36    [W:3.088 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site