Messages in this thread | | | Date | Tue, 28 Dec 2021 16:56:11 +0100 | From | Matthias Brugger <> | Subject | Re: [PATCH 3/3] This adds a DT binding documentation for the MT6582 SoC |
| |
On 22/12/2021 18:32, Rob Herring wrote: > On Sun, Dec 19, 2021 at 11:31:34PM +0500, Maxim Kutnij wrote: >> This adds a DT binding documentation for the MT6582 SoC. > > Please follow the convention used for other commits of these files in > the subject: > > dt-bindings: mediatek: ... > > (That's true for all commits in the kernel) >
I fixed that for you. I also fixed the order of the timer and SoC compatible.
All three patches are now pushed to v5.17-tmp/dts32 [1] This branch will be renamed to v5.17-next/dts32 after v5.17-rc1 is released.
Hope to see more patches from you to enable other drivers of the SoC.
Thanks!
[1] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/
>> >> Signed-off-by: Maxim Kutnij <gtk3@inbox.ru> >> --- >> Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++ >> .../devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 + >> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 + >> 3 files changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >> index 0fa55497b96..fedce0d0f3f 100644 >> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >> @@ -26,6 +26,10 @@ properties: >> - enum: >> - mediatek,mt2712-evb >> - const: mediatek,mt2712 >> + - items: >> + - enum: >> + - prestigio,pmt5008-3g >> + - const: mediatek,mt6582 >> - items: >> - enum: >> - mediatek,mt6580-evbp1 >> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> index e5c57d6e018..62acdb11aff 100644 >> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> @@ -11,6 +11,7 @@ Required properties: >> - compatible should contain: >> For those SoCs that use GPT >> * "mediatek,mt2701-timer" for MT2701 compatible timers (GPT) >> + * "mediatek,mt6582-timer" for MT6582 compatible timers (GPT) >> * "mediatek,mt6580-timer" for MT6580 compatible timers (GPT) >> * "mediatek,mt6589-timer" for MT6589 compatible timers (GPT) >> * "mediatek,mt7623-timer" for MT7623 compatible timers (GPT) >> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> index 0114871f887..a97418c74f6 100644 >> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> @@ -8,6 +8,7 @@ Required properties: >> - compatible should contain: >> "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701 >> "mediatek,mt2712-wdt": for MT2712 >> + "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582 >> "mediatek,mt6589-wdt": for MT6589 >> "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797 >> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622 >> -- >> 2.34.1 >> >>
| |