Messages in this thread | | | Date | Mon, 27 Dec 2021 22:26:02 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v9 01/15] modpost: fix removing numeric suffixes |
| |
On Mon, Dec 27, 2021 at 07:22:46PM +0100, Alexander Lobakin wrote: > It's just a couple lines below. I trigger this using `-z uniq-symbol` > which uses numeric suffixes for globals as well.
Aha, so that's for the fgkaslr purposes now.
> It fixes a commit dated 2014, thus Cc:stable. Although the > remove_dot() might've been introduced for neverlanded GCC LTO, but > in fact numeric suffixes are used a lot by the toolchains in regular > builds as well. Just not for globals, that's why it's "well hidden".
Does "well hidden" warrant a stable backport then? Because if no toolchain is using numeric suffixes for globals, then no need for the stable tag, I'd say.
> I thought it's a common saying in commit messages, isn't it?
Lemme give you my canned and a lot more eloquent explanation for that:
"Please use passive voice in your commit message: no "we" or "I", etc, and describe your changes in imperative mood.
Also, pls read section "2) Describe your changes" in Documentation/process/submitting-patches.rst for more details.
Also, see section "Changelog" in Documentation/process/maintainer-tip.rst
Bottom line is: personal pronouns are ambiguous in text, especially with so many parties/companies/etc developing the kernel so let's avoid them please."
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |