Messages in this thread | | | From | Martin Blumenstingl <> | Date | Mon, 27 Dec 2021 19:10:39 +0100 | Subject | Re: [PATCH] reset: reset-meson: add support for the Meson-S4 SoC Reset Controller |
| |
Hello,
thank you for this patch!
On Mon, Dec 27, 2021 at 10:01 AM Zelong Dong <zelong.dong@amlogic.com> wrote: > > Signed-off-by: Zelong Dong <zelong.dong@amlogic.com> Most maintainers don't take patches without a proper description. ./scripts/checkpatch.pl this.patch states: WARNING: Missing commit description - Add an appropriate one
I suggest something like: "Compared to the A1 SoCs the number of RESET registers is different and the offset for the level registers is the same. Add a new compatible string and struct meson_reset_param to add support for the reset controller on the S4 SoC."
[...] > + { .compatible = "amlogic,meson-s4-reset", .data = &meson_s4_param}, checkpatch reports here: WARNING: DT compatible string "amlogic,meson-s4-reset" appears un-documented -- check ./Documentation/devicetree/bindings/
My suggestion is to take your previous dt-bindings patch for the reset controller and to extend it with one entry in Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml just like it was done for the A1 SoC: [0] Then take both patches (dt-binding and driver) and send them as one series, so it's clear to the reset-maintainers and reviewers that these patches belong together.
Best regards, Martin
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d9730b9eb05a349c278a9f6f058ebefa9063def
| |