Messages in this thread | | | Date | Mon, 27 Dec 2021 14:31:51 +0530 | From | Pratyush Yadav <> | Subject | Re: [PATCH 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq |
| |
On 24/12/21 06:45PM, Potin Lai wrote: > Add support for winbond w25q01jv-iq chip > > Signed-off-by: Potin Lai <potin.lai@quantatw.com> > --- > drivers/mtd/spi-nor/winbond.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c > index c783ab4ba1e4..a2a72d05fc28 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -104,6 +104,8 @@ static const struct flash_info winbond_parts[] = { > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) }, > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024, > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > + { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
We recently reworked how flags are set. Please use the new flags variants. See [0] If the flash supports SFDP then we prefer you only set the PARSE_SFDP flag. See [1].
You also need to show the dumps of the SFDP and other flash parameters. See [2].
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/next&id=ec1c0e996035c8f93eca7bb64ccf0411b57fddea [1] https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?h=spi-nor/next&id=1c513c986b0a4c7151cb4571e568136f16c9dc58 [2] https://patchwork.ozlabs.org/project/linux-mtd/patch/20211209190436.401946-2-tudor.ambarus@microchip.com/
> }; > > /** > -- > 2.17.1 >
-- Regards, Pratyush Yadav Texas Instruments Inc.
| |