lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] ima: silence measurement list hexdump during kexec
From
Date
On Mon, 2021-12-27 at 11:52 -0300, Bruno Meneguele wrote:
> The measurement list is being dumped during soft resets (kexec) through the
> call to print_hex_dump(KERN_DEBUG, ...) without considering the DEBUG
> compilation flag. With that, to avoid dumping this information to the system
> log whenever a soft reset happens during boot process, since the default
> console loglevel is generally set to 7 (debug) during boot, guard the call
> to print_hex_dump() with #ifdef for the DEBUG cflag.

The patch description needs to be rewritten/simplified. If the only
problem is that "the console loglevel is generally set to 7 (debug)",
why not begin with the patch description with that?

Other things to consider including in the patch description:
- any side effects of the change (e.g. ability to dynamically enable
output)?

thanks,

Mimi

\
 
 \ /
  Last update: 2021-12-27 16:57    [W:0.038 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site