Messages in this thread | | | Date | Sun, 26 Dec 2021 11:45:16 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH] coccinelle: adjust the confidence of uninitialized_var.cocci |
| |
On Tue, 14 Dec 2021, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com> > > Since uninitialized_var() was removed, this cocci should reset its > confidence to low.
I'm not sure to understand the argument for this one. The semantic patch in its current state is looking for declarations that hide an uninitialized variable. The part about the uninitialized_var macro is not there any more. The problem that is searched for seems reasonable to address.
julia
> > Signed-off-by: Wang Qing <wangqing@vivo.com> > --- > scripts/coccinelle/misc/uninitialized_var.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/uninitialized_var.cocci b/scripts/coccinelle/misc/uninitialized_var.cocci > index 69bbaae..79e02e3 > --- a/scripts/coccinelle/misc/uninitialized_var.cocci > +++ b/scripts/coccinelle/misc/uninitialized_var.cocci > @@ -18,7 +18,7 @@ > /// this kind were cleaned-up from the kernel. This cocci rule checks that > /// the macro is not explicitly or implicitly reintroduced. > /// > -// Confidence: High > +// Confidence: Low > // Copyright: (C) 2020 Denis Efremov ISPRAS > // Options: --no-includes --include-headers > // > -- > 2.7.4 > >
| |