Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] powerpc/sysdev/of_rtc: Fix possible memory leak in of_instantiate_rtc | From | He Ying <> | Date | Mon, 27 Dec 2021 11:33:51 +0800 |
| |
Ping. Any ideas about this patch?
在 2021/11/3 9:47, He Ying 写道: > If of_address_to_resource() in of_instantiate_rtc() fails, previously > allocated memory res is not freed. Add missing kfree() for it. > > Signed-off-by: He Ying <heying24@huawei.com> > --- > arch/powerpc/sysdev/of_rtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/sysdev/of_rtc.c b/arch/powerpc/sysdev/of_rtc.c > index 1f408d34a6a7..23b896996c2f 100644 > --- a/arch/powerpc/sysdev/of_rtc.c > +++ b/arch/powerpc/sysdev/of_rtc.c > @@ -44,6 +44,7 @@ void __init of_instantiate_rtc(void) > printk(KERN_ERR "OF RTC: Error " > "translating resources for %pOF\n", > node); > + kfree(res); > continue; > } >
| ![\](/images/icornerr.gif) |