Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 26 Dec 2021 10:40:54 +0200 | Subject | Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt |
| |
On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
...
> > > + if (np) { > > > > Same comments as per your other patches, i.e. > > Why is this check here? > > > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case.
Shouldn't be fixed in platform_get_irq_optional() to return IRQ by index for all cases?
> [0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454
-- With Best Regards, Andy Shevchenko
| |