Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 23 Dec 2021 14:37:06 +0200 | Subject | Re: [PATCH v2] drivers: net: smc911x: Check for error irq |
| |
On Thu, Dec 23, 2021 at 2:33 PM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote: > On Thursday, December 23, 2021, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > Do other way around. > > ret = ... > > if (ret < 0) > > ... > > irq = ret; > > This version I correct the patch by using error variable, too. > And the commit message is as follow. > > Because platform_get_irq() could fail and return error irq. > Therefore, it might be better to check it in order to avoid the use of > error irq.
Fix commit message and send v3.
-- With Best Regards, Andy Shevchenko
| |