Messages in this thread | | | Date | Thu, 23 Dec 2021 12:31:06 +0300 | Subject | Re: [PATCH] ata: libahci_platform: Remove abundant check | From | Sergey Shtylyov <> |
| |
Hello!
On 22.12.2021 10:24, Jiasheng Jiang wrote:
> It can be found that platform_get_irq() returns nagative code but not > null when fails.
s/null/zero/?
> The comment of the platform_get_irq clearly shows that.
This comment still doesn't correspond to reality -- 0 can be returned (although this would cause a WARN() call)...
> Therefore it should be better to remove the useless check.
This patch is correct but premature. I have a (not yet merged) patch:
https://marc.info/?l=linux-kernel&m=163623041902285
It actually disables reporting IRQ0. Until it's merged we have to filter out IRQ0 in the libata drivers as libata treats 0 as an indication of the polling mode...
> Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> [...]
MBR, Sergey
| |