lkml.org 
[lkml]   [2021]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v2 32/48] perf script: Use for each cpu to aid readability
    From
    Use perf_cpu_map__for_each_cpu to help with readability.

    Signed-off-by: Ian Rogers <irogers@google.com>
    ---
    tools/perf/builtin-script.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
    index 9434367af166..af06fe1271cc 100644
    --- a/tools/perf/builtin-script.c
    +++ b/tools/perf/builtin-script.c
    @@ -2113,8 +2113,7 @@ static struct scripting_ops *scripting_ops;
    static void __process_stat(struct evsel *counter, u64 tstamp)
    {
    int nthreads = perf_thread_map__nr(counter->core.threads);
    - int ncpus = evsel__nr_cpus(counter);
    - int cpu, thread;
    + int idx, cpu, thread;
    static int header_printed;

    if (counter->core.system_wide)
    @@ -2127,13 +2126,13 @@ static void __process_stat(struct evsel *counter, u64 tstamp)
    }

    for (thread = 0; thread < nthreads; thread++) {
    - for (cpu = 0; cpu < ncpus; cpu++) {
    + perf_cpu_map__for_each_cpu(cpu, idx, evsel__cpus(counter)) {
    struct perf_counts_values *counts;

    counts = perf_counts(counter->counts, cpu, thread);

    printf("%3d %8d %15" PRIu64 " %15" PRIu64 " %15" PRIu64 " %15" PRIu64 " %s\n",
    - counter->core.cpus->map[cpu],
    + cpu,
    perf_thread_map__pid(counter->core.threads, thread),
    counts->val,
    counts->ena,
    --
    2.34.1.307.g9b7440fafd-goog
    \
     
     \ /
      Last update: 2021-12-23 08:49    [W:2.521 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site