lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] software node: fix wrong node passed to find nargs_prop
    On Mon, Dec 20, 2021 at 10:05:33PM +0100, Clément Léger wrote:
    > nargs_prop refers to a property located in the reference that is found
    > within the nargs property. Use the correct reference node in call to
    > property_entry_read_int_array() to retrieve the correct nargs value.
    >
    > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
    > Signed-off-by: Clément Léger <clement.leger@bootlin.com>

    Thank you (and thanks to Andy for cc'ing me).

    Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>

    > ---
    > drivers/base/swnode.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
    > index 4debcea4fb12..0a482212c7e8 100644
    > --- a/drivers/base/swnode.c
    > +++ b/drivers/base/swnode.c
    > @@ -529,7 +529,7 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
    > return -ENOENT;
    >
    > if (nargs_prop) {
    > - error = property_entry_read_int_array(swnode->node->properties,
    > + error = property_entry_read_int_array(ref->node->properties,
    > nargs_prop, sizeof(u32),
    > &nargs_prop_val, 1);
    > if (error)

    --
    Sakari Ailus

    \
     
     \ /
      Last update: 2021-12-21 12:53    [W:8.910 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site