Messages in this thread | | | Date | Tue, 21 Dec 2021 20:09:05 -0400 | From | Jason Gunthorpe <> | Subject | Re: [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup |
| |
On Tue, Dec 21, 2021 at 03:58:48PM -0800, David E. Box wrote: > Depends on "driver core: auxiliary bus: Add driver data helpers" patch [1]. > Applies the helpers to all auxiliary device drivers using > dev_(get/set)_drvdata. Drivers were found using the following search: > > grep -lr "struct auxiliary_device" $(grep -lr "drvdata" .) > > Changes were build tested using the following configs: > > vdpa/mlx5: CONFIG_MLX5_VDPA_NET > net/mlx53: CONFIG_MLX5_CORE_EN > soundwire/intel: CONFIG_SOUNDWIRE_INTEL > RDAM/irdma: CONFIG_INFINIBAND_IRDMA > CONFIG_MLX5_INFINIBAND > > [1] https://www.spinics.net/lists/platform-driver-x86/msg29940.html
I have to say I don't really find this to be a big readability improvement.
Also, what use is 'to_auxiliary_dev()' ? I didn't see any users added..
Jason
| |