Messages in this thread | | | From | "Ismail, Mohammad Athari" <> | Subject | RE: [BUG] net: phy: genphy_loopback: add link speed configuration | Date | Wed, 15 Dec 2021 15:03:52 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Wednesday, December 15, 2021 5:55 PM > To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Voon, Weifeng <weifeng.voon@intel.com>; > Wong, Vee Khee <vee.khee.wong@intel.com> > Subject: Re: [BUG] net: phy: genphy_loopback: add link speed configuration > > > > -----Original Message----- > > > From: Andrew Lunn <andrew@lunn.ch> > > > Sent: Wednesday, December 15, 2021 5:23 PM > > > To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com> > > > Cc: Oleksij Rempel <o.rempel@pengutronix.de>; > > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Voon, Weifeng > > > <weifeng.voon@intel.com>; Wong, Vee Khee > <vee.khee.wong@intel.com> > > > Subject: Re: [BUG] net: phy: genphy_loopback: add link speed > > > configuration > > > > > > > Thanks for the suggestion. The proposed solution also doesn't > > > > work. Still > > > get -110 error. > > > > > > Please can you trace where this -110 comes from. Am i looking at the > > > wrong poll call? > > > > I did read the ret value from genphy_soft_reset() and > phy_read_poll_timeout(). > > The -110 came from phy_read_poll_timeout(). > > O.K. > > Does the PHY actually do loopback, despite the -110?
As Intel Elkhart Lake is using stmmac driver, in stmmac_selftest, return value of phy_loopback() is checked as well. If it return -110, the selftest that using PHY loopback will be recorded as -110 (fail).
> > I'm wondering if we should ignore the return value from > phy_read_poll_timeout().
Removing/ignoring the return value from phy_read_poll_timeout() can work. But, the -110 error message will be displayed in dmesg. It is because there is phydev_err() as part of phy_read_poll_timeout() definition.
-Athari-
> > Andrew
| |