lkml.org 
[lkml]   [2021]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] wilc1000: Remove misleading USE_SPI_DMA macro
From
Date
David Mosberger-Tang <davidm@egauge.net> wrote:

> The USE_SPI_DMA macro name suggests that it could be set to 1 to
> control whether or not SPI DMA should be used. However, that's not
> what it does. If set to 1, it'll set the SPI messages'
> "is_dma_mapped" flag to true, even though the tx/rx buffers aren't
> actually DMA mapped by the driver. In other words, setting this flag
> to 1 will break the driver.
>
> Best to clean up this confusion by removing the macro altogether.
> There is no need to explicitly initialize "is_dma_mapped" because the
> message is cleared to zero anyhow, so "is_dma_mapped" is set to false
> by default.
>
> Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>

Patch applied to wireless-drivers-next.git, thanks.

dde02213fa64 wilc1000: Remove misleading USE_SPI_DMA macro

--
https://patchwork.kernel.org/project/linux-wireless/patch/20211207002453.3193737-1-davidm@egauge.net/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2021-12-14 19:45    [W:0.030 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site