Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 14 Dec 2021 19:37:47 +0200 | Subject | Re: [PATCH v5 3/5] pinctrl: qcom: Extract chip specific LPASS LPI code |
| |
On Tue, Dec 14, 2021 at 7:22 PM Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> wrote: > On 12/14/2021 10:46 PM, Andy Shevchenko wrote: > > On Tue, Dec 14, 2021 at 7:15 PM Srinivasa Rao Mandadapu > > <quic_srivasam@quicinc.com> wrote: > >> On 12/8/2021 11:58 AM, Andy Shevchenko wrote:
...
> >>>> +struct lpi_pingroup { > >>>> + const char *name; > >>>> + const unsigned int *pins; > >>>> + unsigned int npins; > >>>> + unsigned int pin; > >>>> + /* Bit offset in slew register for SoundWire pins only */ > >>>> + int slew_offset; > >>>> + unsigned int *funcs; > >>>> + unsigned int nfuncs; > >>>> +}; > >>> Are you going to convert this to use struct group_desc? > > Any comments on this? It sounds like further improvements. > Actually this also needs as separate patch. these patches will do as > separate series.
Of course, that's why I put the second sentence after the question in my reply.
-- With Best Regards, Andy Shevchenko
| |