lkml.org 
[lkml]   [2021]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source
    Date


    > -----Original Message-----
    > From: Leo Li <leoyang.li@nxp.com>
    > Sent: 2021年12月14日 14:17
    > To: Shawn Guo <shawnguo@kernel.org>
    > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Biwen
    > Li <biwen.li@nxp.com>
    > Subject: RE: [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be
    > used as wakeup source
    >
    >
    >
    > > -----Original Message-----
    > > From: Shawn Guo <shawnguo@kernel.org>
    > > Sent: Tuesday, December 14, 2021 1:46 PM
    > > To: Leo Li <leoyang.li@nxp.com>
    > > Cc: linux-arm-kernel@lists.infradead.org;
    > > linux-kernel@vger.kernel.org; Biwen Li <biwen.li@nxp.com>
    > > Subject: Re: [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node
    > > to be used as wakeup source
    > >
    > > On Fri, Dec 03, 2021 at 06:17:12PM -0600, Li Yang wrote:
    > > > From: Biwen Li <biwen.li@nxp.com>
    > > >
    > > > Add flextimer2 based ftm_alarm1 node and enable it to be the default
    > > > rtc wakeup source for rdb and qds boards instead of the original
    > > > flextimer1 based ftm_alarm0. The ftm_alarm0 node hence is disabled
    > > > by
    > > default.
    > >
    > > What's wrong with using ftm_alarm0?
    >
    > Not 100% sure, but probably because we need to use flextimer1 as PWM.
    >>> Yes, flextime1 is used as PWM. So use flextimer2 as rtc.
    >
    > Biwen, Can you comment?
    >
    > >
    > > Shawn
    > >
    > > >
    > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
    > > > Signed-off-by: Li Yang <leoyang.li@nxp.com>
    > > > ---
    > > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 6 +++++-
    > > > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 6 +++++-
    > > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 9 +++++++++
    > > > 3 files changed, 19 insertions(+), 2 deletions(-)
    > > >
    > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
    > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
    > > > index 6e2a1da662fb..00d5b81bdef3 100644
    > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
    > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
    > > > @@ -25,7 +25,7 @@ aliases {
    > > > serial1 = &duart1;
    > > > mmc0 = &esdhc;
    > > > mmc1 = &esdhc1;
    > > > - rtc1 = &ftm_alarm0;
    > > > + rtc1 = &ftm_alarm1;
    > > > };
    > > >
    > > > chosen {
    > > > @@ -234,6 +234,10 @@ mt35xu02g0: flash@0 {
    > > > };
    > > > };
    > > >
    > > > +&ftm_alarm1 {
    > > > + status = "okay";
    > > > +};
    > > > +
    > > > &i2c0 {
    > > > status = "okay";
    > > >
    > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
    > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
    > > > index 7719f44bcaed..41900d351a92 100644
    > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
    > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
    > > > @@ -21,7 +21,7 @@ aliases {
    > > > serial1 = &duart1;
    > > > mmc0 = &esdhc;
    > > > mmc1 = &esdhc1;
    > > > - rtc1 = &ftm_alarm0;
    > > > + rtc1 = &ftm_alarm1;
    > > > };
    > > >
    > > > chosen {
    > > > @@ -132,6 +132,10 @@ mt35xu02g0: flash@0 {
    > > > };
    > > > };
    > > >
    > > > +&ftm_alarm1 {
    > > > + status = "okay";
    > > > +};
    > > > +
    > > > &i2c0 {
    > > > status = "okay";
    > > >
    > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > > index 9efcaf68578c..ef9d17df2afa 100644
    > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > > @@ -1198,6 +1198,15 @@ ftm_alarm0: timer@2800000 {
    > > > reg = <0x0 0x2800000 0x0 0x10000>;
    > > > fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000
    > > 0x0 0x0>;
    > > > interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
    > > > + status = "disabled";
    > > > + };
    > > > +
    > > > + ftm_alarm1: timer@2810000 {
    > > > + compatible = "fsl,ls1028a-ftm-alarm";
    > > > + reg = <0x0 0x2810000 0x0 0x10000>;
    > > > + fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000
    > > 0x0 0x0>;
    > > > + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
    > > > + status = "disabled";
    > > > };
    > > > };
    > > >
    > > > --
    > > > 2.25.1
    > > >
    \
     
     \ /
      Last update: 2021-12-14 07:20    [W:5.683 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site