Messages in this thread | | | Date | Tue, 14 Dec 2021 13:41:29 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first parameter in orion_gpio_init() |
| |
On Tue, Dec 14, 2021 at 03:32:43PM +0200, Andy Shevchenko wrote: > The OF node pointer is always NULL, get rid of unused parameter in > orion_gpio_init(). As a side effect it will allow to switch GPIO > library to the fwnode API, as well as in case of resurrecting it here > it should be fwnode_handle anyways.
Please ensure the new code follows the existing style - especially in terms of wrapping. Some of us still use 80 columns as a general rule. Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |