lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 054/171] net: dsa: felix: Fix memory leak in felix_setup_mmio_filtering
    Date
    From: José Expósito <jose.exposito89@gmail.com>

    commit e8b1d7698038e76363859fb47ae0a262080646f5 upstream.

    Avoid a memory leak if there is not a CPU port defined.

    Fixes: 8d5f7954b7c8 ("net: dsa: felix: break at first CPU port during init and teardown")
    Addresses-Coverity-ID: 1492897 ("Resource leak")
    Addresses-Coverity-ID: 1492899 ("Resource leak")
    Signed-off-by: José Expósito <jose.exposito89@gmail.com>
    Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    Link: https://lore.kernel.org/r/20211209110538.11585-1-jose.exposito89@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/dsa/ocelot/felix.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/net/dsa/ocelot/felix.c
    +++ b/drivers/net/dsa/ocelot/felix.c
    @@ -290,8 +290,11 @@ static int felix_setup_mmio_filtering(st
    }
    }

    - if (cpu < 0)
    + if (cpu < 0) {
    + kfree(tagging_rule);
    + kfree(redirect_rule);
    return -EINVAL;
    + }

    tagging_rule->key_type = OCELOT_VCAP_KEY_ETYPE;
    *(__be16 *)tagging_rule->key.etype.etype.value = htons(ETH_P_1588);

    \
     
     \ /
      Last update: 2021-12-13 11:21    [W:6.467 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site