Messages in this thread | | | Subject | Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema | From | Jayesh Choudhary <> | Date | Tue, 14 Dec 2021 10:27:58 +0530 |
| |
On 11/12/21 2:54 am, Rob Herring wrote: > On Fri, Dec 03, 2021 at 05:32:43PM +0530, Jayesh Choudhary wrote: >> Convert the bindings for McASP controllers for TI SOCs from txt >> to YAML schema. >> >> Adds additional properties 'clocks', 'clock-names', 'power-domains', >> '#sound-dai-cells' and 'port' which were missing from txt file. >> Removes properties 'sram-size-playback' and 'sram-size-capture' >> since they are not used. >> Adds 'dmas' and 'dma-names' in the example which were missing from >> the txt file. >> Changes 'interrupts' and 'interrupt-names' from optional to >> required properties. >> Changes 'op-mode', 'serial-dir' and 'tdm-slots' to optional properties >> as they are not needed if the McASP is used only as GPIO. >> >> Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS >> INSTRUMENTS ASoC DRIVERS' >> >> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> >> ---
>> + >> + tdm-slots: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: number of channels over one serializer >> + maxItems: 1 > > It's a uint32, so there's always 1 item. Drop. >
Will drop it from tdm-slots, tx-num-evt, rx-num-evt and auxclk-fs-ratio since they are also uint32.
> No constraints? 0-2^32 is valid?
Yes it should be between 2 to 32 as pointed out by Peter. Will add that.
> >> + >> + >> + tx-num-evt: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: configures WFIFO threshold >> + maxItems: 1 >> + >> + rx-num-evt: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: configures RFIFO threshold >> + maxItems: 1 >> + >> + >> + auxclk-fs-ratio: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: ratio of AUCLK and FS rate if applicable >> + maxItems: 1 >> +
>> +additionalProperties: false >> + >> +examples: >> + - | >> + mcasp0: mcasp0@1d00000 { > > Drop unused labels.
Yeah okay.
> >> + compatible = "ti,da830-mcasp-audio"; >> + reg = <0x100000 0x3000>; >> + reg-names = "mpu"; >> + interrupts = <82>, <83>; >> + interrupt-names = "tx", "rx"; >> + op-mode = <0>; /* MCASP_IIS_MODE */ >> + tdm-slots = <2>; >> + dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>; >> + dma-names = "tx", "rx"; >> + serial-dir = < >> + 0 0 0 0 /* 0: INACTIVE, 1: TX, 2: RX */ >> + 0 0 0 0 >> + 0 0 0 1 >> + 2 0 0 0 >; >> + tx-num-evt = <1>; >> + rx-num-evt = <1>; >> + }; >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 00ad0cb5cb05..3fdf1e23f7d7 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -18855,6 +18855,7 @@ TEXAS INSTRUMENTS ASoC DRIVERS >> M: Peter Ujfalusi <peter.ujfalusi@gmail.com> >> L: alsa-devel@alsa-project.org (moderated for non-subscribers) >> S: Maintained >> +F: Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml >> F: sound/soc/ti/ >> >> TEXAS INSTRUMENTS' DAC7612 DAC DRIVER >> -- >> 2.17.1 >> >>
| |