Messages in this thread | | | Date | Mon, 13 Dec 2021 18:41:52 +0000 | From | Will Deacon <> | Subject | Re: [PATCH] locking/ww-mutex: use swap() to make code cleaner |
| |
On Thu, Nov 04, 2021 at 08:18:46AM +0800, davidcomponentone@gmail.com wrote: > From: Yang Guang <yang.guang5@zte.com.cn> > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > opencoding it. > > Signed-off-by: Yang Guang <yang.guang5@zte.com.cn> > Reported-by: Zeal Robot <zealci@zte.com.cn> > --- > kernel/locking/test-ww_mutex.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c > index 353004155d65..daad819fcd16 100644 > --- a/kernel/locking/test-ww_mutex.c > +++ b/kernel/locking/test-ww_mutex.c > @@ -389,7 +389,7 @@ struct stress { > static int *get_random_order(int count) > { > int *order; > - int n, r, tmp; > + int n, r; > > order = kmalloc_array(count, sizeof(*order), GFP_KERNEL); > if (!order) > @@ -401,9 +401,7 @@ static int *get_random_order(int count) > for (n = count - 1; n > 1; n--) { > r = get_random_int() % (n + 1); > if (r != n) { > - tmp = order[n]; > - order[n] = order[r]; > - order[r] = tmp; > + swap(order[n], order[r]);
Looks correct to me:
Acked-by: Will Deacon <will@kernel.org>
Will
| |