Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 13 Dec 2021 19:30:28 +0100 | Subject | Re: [PATCH -next] selftests: gpio: gpio-sim: remove bashisms |
| |
On Mon, Dec 13, 2021 at 5:39 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Dec 13, 2021 at 05:26:25PM +0100, Bartosz Golaszewski wrote: > > '==' is a bashisms and not understood by POSIX shell. Drop it from > > gpio-sim selftests. > > > - if [ "$BANK" == "live" ] || [ "$BANK" == "dev_name" ]; then > > + if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then > > While at it, no need to fork `test` twice, isn't it? > > if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then > > -- > With Best Regards, > Andy Shevchenko > >
I'll send a follow-up for that, thanks for spotting it.
Bart
| |