Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH 4/4] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-makomo | Date | Mon, 13 Dec 2021 10:20:15 -0600 |
| |
On Mon, 13 Dec 2021 15:23:55 +0800, Hsin-Yi Wang wrote: > Makomo is known as Lenovo 100e Gen 2 Chromebook. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > .../devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: properties:compatible:oneOf:31:items: 'oneOf' conditional failed, one must be fixed: [{'enum': [{'const': 'google,makomo-rev4-sku0'}, {'const': 'google,makomo-rev5-sku0'}, {'const': 'google,makomo'}, {'const': 'mediatek,mt8183'}]}] is not of type 'object' {'const': 'google,makomo-rev4-sku0'} is not of type 'string' {'const': 'google,makomo-rev5-sku0'} is not of type 'string' {'const': 'google,makomo'} is not of type 'string' {'const': 'mediatek,mt8183'} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: properties:compatible:oneOf:32:items: 'oneOf' conditional failed, one must be fixed: [{'enum': [{'const': 'google,makomo-rev4-sku1'}, {'const': 'google,makomo-rev5-sku1'}, {'const': 'google,makomo'}, {'const': 'mediatek,mt8183'}]}] is not of type 'object' {'const': 'google,makomo-rev4-sku1'} is not of type 'string' {'const': 'google,makomo-rev5-sku1'} is not of type 'string' {'const': 'google,makomo'} is not of type 'string' {'const': 'mediatek,mt8183'} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/mediatek.yaml: ignoring, error in schema: properties: compatible: oneOf: 31: items warning: no schema found in file: ./Documentation/devicetree/bindings/arm/mediatek.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1567163
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |