lkml.org 
[lkml]   [2021]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 4/6] irqchip/apple-aic: Dynamically compute register offsets
    On Thu, 09 Dec 2021 04:32:47 +0000,
    Hector Martin <marcan@marcan.st> wrote:
    >
    > This allows us to support AIC variants with different numbers of IRQs
    > based on capability registers.
    >
    > Signed-off-by: Hector Martin <marcan@marcan.st>
    > ---
    > drivers/irqchip/irq-apple-aic.c | 73 +++++++++++++++++++++++++--------
    > 1 file changed, 56 insertions(+), 17 deletions(-)
    >
    > diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
    > index 572d1af175fc..d03caed51d56 100644
    > --- a/drivers/irqchip/irq-apple-aic.c
    > +++ b/drivers/irqchip/irq-apple-aic.c
    > @@ -312,12 +326,15 @@ static int aic_irq_set_affinity(struct irq_data *d,
    > struct aic_irq_chip *ic = irq_data_get_irq_chip_data(d);
    > int cpu;
    >
    > + if (!ic->info.target_cpu)
    > + return -EINVAL;

    Can this even happen? And if it did, this should scream loudly,
    shouldn't it?

    M.

    --
    Without deviation from the norm, progress is not possible.

    \
     
     \ /
      Last update: 2021-12-12 19:27    [W:3.215 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site