Messages in this thread | | | Date | Sat, 11 Dec 2021 13:44:47 +0800 | Subject | Re: [Linux-cachefs] [RFC 09/19] netfs: refactor netfs_rreq_unlock() | From | JeffleXu <> |
| |
On 12/11/21 1:23 PM, JeffleXu wrote: > > > On 12/10/21 11:41 PM, David Howells wrote: >> Jeffle Xu <jefflexu@linux.alibaba.com> wrote: >> >>> In demand-read case, the input folio of netfs API is may not the page >> >> "is may not the page"? I think you're missing a verb (and you have too many >> auxiliary verbs;-) >> > > Sorry for my poor English... What I want to express is that > > "In demand-read case, the input folio of netfs API may not be the page > cache inside the address space of the netfs file." >
By the way, can we change the current address_space based netfs API to folio-based, which shall be more general? That is, the current implementation of netfs API uses (address_space, page_offset, len) tuple to describe the destination where the read data shall be store into. While in the demand-read case, the input folio may not be the page cache, and thus there's no address_space attached with it.
-- Thanks, Jeffle
| |