Messages in this thread | | | Date | Fri, 10 Dec 2021 16:39:05 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] spi: Fix incorrect cs_setup delay handling |
| |
On Sat, Dec 11, 2021 at 01:32:06AM +0900, Hector Martin wrote: > On 11/12/2021 01.21, Mark Brown wrote:
> > This needs a better changelog, there's multiple delays being handled > > here and it's not clear from this which are affected here or what the > > problem is.
> cs_setup is affected, I thought at least that was clear from the patch > summary :-)
This should be in the commit message, the subject line of the e-mail isn't super visible when people are reviewing - basically, the body of the commit message should make sense standalone.
> If you prefer, I can resend it with a reference to the spi.h comment.
Yes, please resend with a clear commit message. [unhandled content-type:application/pgp-signature] | |