lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: irq/core] be2net: Use irq_update_affinity_hint()
    The following commit has been merged into the irq/core branch of tip:

    Commit-ID: b8b9dd525203304d36bd123fca3ce0c3b318339b
    Gitweb: https://git.kernel.org/tip/b8b9dd525203304d36bd123fca3ce0c3b318339b
    Author: Nitesh Narayan Lal <nitesh@redhat.com>
    AuthorDate: Fri, 03 Sep 2021 11:24:24 -04:00
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitterDate: Fri, 10 Dec 2021 20:47:39 +01:00

    be2net: Use irq_update_affinity_hint()

    The driver uses irq_set_affinity_hint() to update the affinity_hint mask
    that is consumed by the userspace to distribute the interrupts. However,
    under the hood irq_set_affinity_hint() also applies the provided cpumask
    (if not NULL) as the affinity for the given interrupt which is an
    undocumented side effect.

    To remove this side effect irq_set_affinity_hint() has been marked
    as deprecated and new interfaces have been introduced. Hence, replace the
    irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
    that only updates the affinity_hint pointer.

    Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/20210903152430.244937-9-nitesh@redhat.com

    ---
    drivers/net/ethernet/emulex/benet/be_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
    index d51f24c..84b3ba9 100644
    --- a/drivers/net/ethernet/emulex/benet/be_main.c
    +++ b/drivers/net/ethernet/emulex/benet/be_main.c
    @@ -3491,7 +3491,7 @@ static int be_msix_register(struct be_adapter *adapter)
    if (status)
    goto err_msix;

    - irq_set_affinity_hint(vec, eqo->affinity_mask);
    + irq_update_affinity_hint(vec, eqo->affinity_mask);
    }

    return 0;
    @@ -3552,7 +3552,7 @@ static void be_irq_unregister(struct be_adapter *adapter)
    /* MSIx */
    for_all_evt_queues(adapter, eqo, i) {
    vec = be_msix_vec_get(adapter, eqo);
    - irq_set_affinity_hint(vec, NULL);
    + irq_update_affinity_hint(vec, NULL);
    free_irq(vec, eqo);
    }

    \
     
     \ /
      Last update: 2021-12-10 20:54    [W:8.919 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site