lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/2] blk-throtl: move WARN_ON_ONCE() from throtl_rb_first() to it's caller
    Date
    Prepare to reintroduce tg_drain_bios(), which will iterate until
    throtl_rb_first() return NULL.

    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    ---
    block/blk-throttle.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/block/blk-throttle.c b/block/blk-throttle.c
    index 39bb6e68a9a2..fdd57878e862 100644
    --- a/block/blk-throttle.c
    +++ b/block/blk-throttle.c
    @@ -502,7 +502,6 @@ throtl_rb_first(struct throtl_service_queue *parent_sq)
    struct rb_node *n;

    n = rb_first_cached(&parent_sq->pending_tree);
    - WARN_ON_ONCE(!n);
    if (!n)
    return NULL;
    return rb_entry_tg(n);
    @@ -521,7 +520,7 @@ static void update_min_dispatch_time(struct throtl_service_queue *parent_sq)
    struct throtl_grp *tg;

    tg = throtl_rb_first(parent_sq);
    - if (!tg)
    + if (WARN_ON_ONCE(!tg))
    return;

    parent_sq->first_pending_disptime = tg->disptime;
    @@ -1090,7 +1089,7 @@ static int throtl_select_dispatch(struct throtl_service_queue *parent_sq)
    break;

    tg = throtl_rb_first(parent_sq);
    - if (!tg)
    + if (WARN_ON_ONCE(!tg))
    break;

    if (time_before(jiffies, tg->disptime))
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-12-01 10:28    [W:7.312 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site