lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] tracing: show size of requested buffer
    On Tue, Oct 26, 2021 at 04:43:43PM -0400, Steven Rostedt wrote:
    > On Thu, 7 Oct 2021 09:23:58 -0400
    > Steven Rostedt <rostedt@goodmis.org> wrote:
    >
    > > On Thu, 7 Oct 2021 09:11:51 +0200
    > > Peter Zijlstra <peterz@infradead.org> wrote:
    > >
    > > > > > +++ b/kernel/trace/trace_event_perf.c
    > > > > > @@ -400,7 +400,8 @@ void *perf_trace_buf_alloc(int size, struct pt_regs **regs, int *rctxp)
    > > > > > BUILD_BUG_ON(PERF_MAX_TRACE_SIZE % sizeof(unsigned long));
    > > > > >
    > > > > > if (WARN_ONCE(size > PERF_MAX_TRACE_SIZE,
    > > > > > - "perf buffer not large enough"))
    > > > > > + "perf buffer not large enough, wanted %d, have %d",
    > > > > > + size, PERF_MAX_TRACE_SIZE))
    > > >
    > > > Priting a constant seems daft.. why is any of this important in any way?
    > >
    > > I see your point, but it can be useful if you changed it, and want to know
    > > if you are running the kernel with the change or not.
    > >
    > > I've done daft things were I changed a const and was running a kernel
    > > without the change and couldn't understand why it wasn't working ;-)
    >
    > Peter,
    >
    > Do you have any real issue if I just take this patch set through my tree?

    No real objections; just weary, huge events like that are fairly sucky
    for performance.

    \
     
     \ /
      Last update: 2021-10-26 23:24    [W:5.226 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site