lkml.org 
[lkml]   [2021]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/11] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
    Date
    whiteout inode should be put when do_tmpfile() failed if inode has been
    initialized. Otherwise we will get following warning during umount:
    UBIFS error (ubi0:0 pid 1494): ubifs_assert_failed [ubifs]: UBIFS
    assert failed: c->bi.dd_growth == 0, in fs/ubifs/super.c:1930
    VFS: Busy inodes after unmount of ubifs. Self-destruct in 5 seconds.

    Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
    Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
    ---
    fs/ubifs/dir.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
    index 2735ad1affed..6503e6857f6e 100644
    --- a/fs/ubifs/dir.c
    +++ b/fs/ubifs/dir.c
    @@ -1334,6 +1334,8 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,

    err = do_tmpfile(old_dir, old_dentry, S_IFCHR | WHITEOUT_MODE, &whiteout);
    if (err) {
    + if (whiteout)
    + iput(whiteout);
    kfree(dev);
    goto out_release;
    }
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-10-25 05:29    [W:5.691 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site