lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] scsi: ufs: Protect PM ops and err_handler from user access through sysfs
    From
    Date
    On Sat, 2021-01-02 at 05:59 -0800, Can Guo wrote:
    > + * @shutting_down: flag to check if shutdown has been invoked

    I am not much sure if this flag is need, since once PM going in
    shutdown path, what will be returnded by pm_runtime_get_sync()?

    If pm_runtime_get_sync() will fail, just check its return.

    Hi Rafael
    would you please help us confirm this?

    thanks,
    Bean


    > + * @host_sem: semaphore used to serialize concurrent contexts
    > * @eh_wq: Workqueue that eh_work works on
    > * @eh_work: Worker to handle UFS errors that require s/w attention
    > * @eeh_work: Worker to handle exception events
    > @@ -751,7 +753,8 @@ struct ufs_hba {
    > u32 intr_mask;
    > u16 ee_ctrl_mask;
    > bool is_powered;
    > - struct semaphore eh_sem;
    > + bool shutting_down;
    > + struct semaphore host_sem;

    \
     
     \ /
      Last update: 2021-01-04 21:06    [W:5.590 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site