Messages in this thread | | | Subject | Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML | From | Shuah Khan <> | Date | Mon, 4 Jan 2021 09:23:57 -0700 |
| |
On 12/22/20 4:11 AM, Andy Shevchenko wrote: > On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote: >> kunit_tool relies on the UML console outputting printk() output to the >> tty in order to get results. Since the default console driver could >> change, pass 'console=tty' to the kernel. >> >> This is triggered by a change[1] to use ttynull as a fallback console >> driver which -- by chance or by design -- seems to have changed the >> default console output on UML, breaking kunit_tool. While this may be >> fixed, we should be less fragile to such changes in the default. >> >> [1]: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=757055ae8dedf5333af17b3b5b4b70ba9bc9da4e > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >
Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Sorry for the delay - have been away from the keyboard for a bit.
thanks, -- Shuah
| |