lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 31/63] media: gp8psk: initialize stats at power control logic
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    commit d0ac1a26ed5943127cb0156148735f5f52a07075 upstream.

    As reported on:
    https://lore.kernel.org/linux-media/20190627222020.45909-1-willemdebruijn.kernel@gmail.com/

    if gp8psk_usb_in_op() returns an error, the status var is not
    initialized. Yet, this var is used later on, in order to
    identify:
    - if the device was already started;
    - if firmware has loaded;
    - if the LNBf was powered on.

    Using status = 0 seems to ensure that everything will be
    properly powered up.

    So, instead of the proposed solution, let's just set
    status = 0.

    Reported-by: syzbot <syzkaller@googlegroups.com>
    Reported-by: Willem de Bruijn <willemb@google.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/usb/dvb-usb/gp8psk.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/usb/dvb-usb/gp8psk.c
    +++ b/drivers/media/usb/dvb-usb/gp8psk.c
    @@ -182,7 +182,7 @@ out_rel_fw:

    static int gp8psk_power_ctrl(struct dvb_usb_device *d, int onoff)
    {
    - u8 status, buf;
    + u8 status = 0, buf;
    int gp_product_id = le16_to_cpu(d->udev->descriptor.idProduct);

    if (onoff) {

    \
     
     \ /
      Last update: 2021-01-04 17:09    [W:5.633 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site