Messages in this thread | | | From | Georgi Djakov <> | Subject | Re: [PATCH v3 3/6] arm64: dts: imx8mq: Add interconnect for lcdif | Date | Mon, 4 Jan 2021 16:54:52 +0200 |
| |
On 12/10/20 12:09, Martin Kepplinger wrote: > Add interconnect ports for lcdif to set bus capabilities. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 3617b7238952..7c4b68bda6fa 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -11,6 +11,7 @@ > #include "dt-bindings/input/input.h" > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/thermal/thermal.h> > +#include <dt-bindings/interconnect/imx8mq.h> > #include "imx8mq-pinfunc.h" > > / { > @@ -522,6 +523,8 @@ > <&clk IMX8MQ_VIDEO_PLL1>, > <&clk IMX8MQ_VIDEO_PLL1_OUT>; > assigned-clock-rates = <0>, <0>, <0>, <594000000>; > + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; > + interconnect-names = "dram"; > status = "disabled"; > > port@0 { >
Nit: IMO, the dt-bindings patch (4/6) should come before this one - first document the DT properties and then use them. Otherwise looks good to me.
Thanks, Georgi
| |